Bootstrap update #148226
Merged
Bootstrap update #148226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 8130721)
|
The Miri subtree was changed cc @rust-lang/miri |
rustbot
added
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use |
|
@bors r+ rollup Nice to see the small amount of cfgs! |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 29, 2025
Rollup of 5 pull requests Successful merges: - #144444 (Contract variable declarations) - #147281 (Make diagnostics clearer for binop-related errors in foreign crates) - #148131 (Skip parameter attribute deduction for MIR with `spread_arg`) - #148224 (bootstrap: `ensure(doc::Std)` no longer opens a browser) - #148226 (Bootstrap update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 29, 2025
Rollup merge of #148226 - cuviper:bootstrap-update, r=Mark-Simulacrum Bootstrap update - Update CURRENT_RUSTC_VERSION post-bump - Bump stage0 to 1.92.0-beta.1 - Update `#[cfg(bootstrap)]`
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Oct 30, 2025
Rollup of 5 pull requests Successful merges: - rust-lang/rust#144444 (Contract variable declarations) - rust-lang/rust#147281 (Make diagnostics clearer for binop-related errors in foreign crates) - rust-lang/rust#148131 (Skip parameter attribute deduction for MIR with `spread_arg`) - rust-lang/rust#148224 (bootstrap: `ensure(doc::Std)` no longer opens a browser) - rust-lang/rust#148226 (Bootstrap update) r? `@ghost` `@rustbot` modify labels: rollup
RalfJung
reviewed
Oct 30, 2025
| #![feature(arbitrary_self_types)] | ||
| #![feature(iter_advance_by)] | ||
| #![cfg_attr(not(bootstrap), feature(duration_from_nanos_u128))] | ||
| #![feature(duration_from_nanos_u128)] |
There was a problem hiding this comment.
FWIW there is a corresponding cfg_select! on bootstrap in the code that matches this... I guess the pattern you are grepping for involves cfg.*bootstrap and so the cfg_select! did not show up?
There was a problem hiding this comment.
Yes, it's just a grep pattern: https://forge.rust-lang.org/release/process.html#default-branch-bootstrap-update-tuesday
Maybe adding bootstrap => and not(bootstrap) => is sufficiently accurate for these cfg_select! cases? That does find your instance right now, and nothing else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#[cfg(bootstrap)]